Skip to content

fix(bonding): add default link monitoring settings for bonding interfaces#1514

Open
m-dilorenzi wants to merge 4 commits intomainfrom
bond_active_backup
Open

fix(bonding): add default link monitoring settings for bonding interfaces#1514
m-dilorenzi wants to merge 4 commits intomainfrom
bond_active_backup

Conversation

@m-dilorenzi
Copy link
Collaborator

@m-dilorenzi m-dilorenzi commented Feb 10, 2026

This pull request introduces default settings for link monitoring on network bonds, ensuring that all bonding interfaces have consistent and reliable monitoring parameters. The changes include both configuration script updates and default values in the device API.

Configuration automation for bond link monitoring:

  • files/etc/uci-defaults/99-nethsec-bond-link-monitoring: Added a script to automatically set link_monitoring to 'mii' and miimon to '100' for all bonding interfaces if they are not already configured, improving bond reliability and consistency.

Default values in device API:

  • packages/ns-api/files/ns.devices: Set default values for link_monitoring ('mii') and miimon ('100') in the bond device configuration dictionary, ensuring new bonds have proper monitoring settings by default.

Closes: #1446

@m-dilorenzi m-dilorenzi requested a review from Tbaile February 10, 2026 16:09
@m-dilorenzi m-dilorenzi self-assigned this Feb 10, 2026
@gsanchietti gsanchietti self-requested a review February 12, 2026 10:20
@m-dilorenzi m-dilorenzi marked this pull request as ready for review February 12, 2026 10:35
@gsanchietti gsanchietti requested a review from Copilot February 12, 2026 10:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds default link monitoring parameters for Linux bonding interfaces to ensure active-backup bonds reliably detect link-down events and fail over, addressing issue #1446.

Changes:

  • Add API-side default bond options link_monitoring='mii' and miimon='100'.
  • Add a /etc/uci-defaults migration script to backfill these options on existing bond configurations when missing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
packages/ns-api/files/ns.devices Adds default bond monitoring fields to the values written by the device API.
files/etc/uci-defaults/99-nethsec-bond-link-monitoring Migration script to set bond monitoring defaults for existing configs if not already configured.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bond in active-backup mode does not switch to backup interface when the primary link goes down

2 participants