fix(bonding): add default link monitoring settings for bonding interfaces#1514
Open
m-dilorenzi wants to merge 4 commits intomainfrom
Open
fix(bonding): add default link monitoring settings for bonding interfaces#1514m-dilorenzi wants to merge 4 commits intomainfrom
m-dilorenzi wants to merge 4 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds default link monitoring parameters for Linux bonding interfaces to ensure active-backup bonds reliably detect link-down events and fail over, addressing issue #1446.
Changes:
- Add API-side default bond options
link_monitoring='mii'andmiimon='100'. - Add a
/etc/uci-defaultsmigration script to backfill these options on existing bond configurations when missing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
packages/ns-api/files/ns.devices |
Adds default bond monitoring fields to the values written by the device API. |
files/etc/uci-defaults/99-nethsec-bond-link-monitoring |
Migration script to set bond monitoring defaults for existing configs if not already configured. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gsanchietti
approved these changes
Feb 13, 2026
gsanchietti
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces default settings for link monitoring on network bonds, ensuring that all bonding interfaces have consistent and reliable monitoring parameters. The changes include both configuration script updates and default values in the device API.
Configuration automation for bond link monitoring:
files/etc/uci-defaults/99-nethsec-bond-link-monitoring: Added a script to automatically setlink_monitoringto'mii'andmiimonto'100'for all bonding interfaces if they are not already configured, improving bond reliability and consistency.Default values in device API:
packages/ns-api/files/ns.devices: Set default values forlink_monitoring('mii') andmiimon('100') in the bond device configuration dictionary, ensuring new bonds have proper monitoring settings by default.Closes: #1446