Skip to content

fix(bonding): add default link monitoring settings for bonding interfaces #1514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-dilorenzi wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix(bonding): add default link monitoring settings for bonding interfaces #1514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
149055b
feat(bonding): add default link monitoring settings for bonding inter…
m-dilorenzi Feb 10, 2026
ef5eed6
feat(bonding): add script for default link monitoring settings in bon…
m-dilorenzi Feb 12, 2026
8023bc9
feat(bonding): streamline link monitoring settings retrieval in bondi…
m-dilorenzi Feb 12, 2026
18d705b
feat(bonding): add arp_interval check before applying default mii mon…
m-dilorenzi Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions files/etc/uci-defaults/99-nethsec-bond-link-monitoring
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
bonds=$(uci show network | grep "='bonding'" | cut -d'.' -f2 | cut -d'=' -f1)

[ -z "$bonds" ] && exit 0

for bond in $bonds; do
miimon_value="$(uci -q get network.$bond.miimon 2>/dev/null)"
link_monitoring_value="$(uci -q get network.$bond.link_monitoring 2>/dev/null)"
arp_interval_value="$(uci -q get network.$bond.arp_interval 2>/dev/null)"

[ -n "$miimon_value" ] && [ -n "$link_monitoring_value" ] && continue
[ -n "$arp_interval_value" ] && continue

miimon_cmd=""
link_monitoring_cmd=""
[ -z "$miimon_value" ] && miimon_cmd="set network.$bond.miimon='100'"
[ -z "$link_monitoring_value" ] && link_monitoring_cmd="set network.$bond.link_monitoring='mii'"
uci -q batch << EOI
$miimon_cmd
$link_monitoring_cmd
commit network
EOI
done
2 changes: 2 additions & 0 deletions packages/ns-api/files/ns.devices
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,8 @@ def get_bonding_values(ip4_addr_cidr, attached_devices, bonding_policy, bond_pri
'clientid': '',
'vendorid': '',
'hostname': '',
'link_monitoring': 'mii', # default link monitoring mode for bonds - Media Independent Interface
'miimon': '100' # default link monitoring interval for bonds - 100ms
}

# ip4 address and netmask
Expand Down
Loading