Skip to content

Fix duplicate API calls in AddInternalProviderModal on modal open#1064

Closed
Copilot wants to merge 2 commits intosdl-7757-addProvidersfrom
copilot/sub-pr-1059
Closed

Fix duplicate API calls in AddInternalProviderModal on modal open#1064
Copilot wants to merge 2 commits intosdl-7757-addProvidersfrom
copilot/sub-pr-1059

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

When opening the AddInternalProviderModal for the first time, getClusterStatus(), listModules(), and listNodes() were called twice - once in the isShown watcher and again in the step watcher triggered by setting step = "node".

Changes

  • Removed duplicate API calls from isShown watcher
  • API calls now execute once through step watcher only
// Before: calls made in isShown watcher
if (!this.isResumeConfiguration) {
  this.step = "node";
  this.getClusterStatus();      // duplicate
  if (!this.isOpenLdap) {
    this.listModules();          // duplicate
    this.listNodes();            // duplicate
  }
}

// After: step watcher handles all calls
if (!this.isResumeConfiguration) {
  this.step = "node";  // triggers step watcher
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…atcher

Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com>
Copilot AI changed the title [WIP] WIP Address feedback on handling additional volumes in samba provider setup Fix duplicate API calls in AddInternalProviderModal on modal open Jan 29, 2026
Copilot AI requested a review from stephdl January 29, 2026 08:30
@stephdl stephdl closed this Jan 29, 2026
@stephdl stephdl deleted the copilot/sub-pr-1059 branch January 29, 2026 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants