Handle additional volumes during samba provider setup#1059
Merged
Conversation
…dling for add-internal-provider
…agement for internal provider setup
stephdl
force-pushed
the
sdl-7757-addProviders
branch
from
6becea1 to
8872f5f
Compare
stephdl
changed the title
…bility checks for provider installation
…ode handling for Samba provider
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the internal provider setup flow by adding support for volume selection when installing the Samba provider and improving error feedback for background tasks. The changes enable users to choose an additional storage volume during Samba installation when available nodes have additional disks.
Changes:
- Added volume selection step in provider installation wizards for Samba when nodes have additional storage
- Implemented cluster status and node storage information retrieval to identify nodes with additional disks
- Enhanced error notifications for get-cluster-status, list-nodes, and list-mountpoints tasks
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| CreateDomainModal.vue | Added volume selection step, cluster status/node storage checks, and improved error notifications for new domain creation with Samba provider |
| AddInternalProviderModal.vue | Added volume selection step, cluster status/node storage checks, and improved error notifications for adding providers to existing domains |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Contributor
8 tasks
Contributor
3 tasks
…dback (#1066) * Initial plan * fix(AddInternalProviderModal): add sambaModule check before accessing sambaVolumes Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com> * refactor(AddInternalProviderModal): combine sambaModule checks for consistency Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com>
…ovider to skip additional storage selection
stephdl
force-pushed
the
sdl-7757-addProviders
branch
from
7f76d19 to
ca52da4
Compare
…ection with additional storage info and loading states
stephdl
force-pushed
the
sdl-7757-addProviders
branch
from
ca52da4 to
9ad2d63
Compare
andre8244
reviewed
Feb 4, 2026
Co-authored-by: Andrea Leardini <andrea.leardini@nethesis.it>
…hecks for LDAP step
…ing of additional volumes in listMountPointsCompleted
…Ds for task registration to improve error handling
andre8244
approved these changes
Feb 5, 2026
…s8-ui-lib version 1.12.0
…ipped volume steps
…w and previous step
…lume on previous step
…selected volume on previous step
…ttonIcon computed property
…n computed property
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the internal provider setup flow (CreateDomainModal and AddInternalProviderModal) by adding clearer error feedback for background tasks and supporting selection of an additional volume when installing the Samba provider.
NethServer/dev#7757