Skip to content

[WIP] Update samba provider setup for additional volumes based on feedback#1066

Merged
stephdl merged 3 commits intosdl-7757-addProvidersfrom
copilot/sub-pr-1059-another-one
Jan 29, 2026
Merged

[WIP] Update samba provider setup for additional volumes based on feedback#1066
stephdl merged 3 commits intosdl-7757-addProvidersfrom
copilot/sub-pr-1059-another-one

Conversation

Copy link
Contributor

Copilot AI commented Jan 29, 2026

  • Add check for sambaModule existence in nodesWithAdditionalStorage computed property before accessing sambaVolumes
  • Combine checks into single condition for consistency with CreateDomainModal.vue
  • Run code review and security checks

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

… sambaVolumes

Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com>
…nsistency

Co-authored-by: stephdl <3164851+stephdl@users.noreply.github.com>
@stephdl stephdl marked this pull request as ready for review January 29, 2026 08:30
@stephdl stephdl merged commit ae1b31d into sdl-7757-addProviders Jan 29, 2026
@stephdl stephdl deleted the copilot/sub-pr-1059-another-one branch January 29, 2026 08:31
Copilot AI requested a review from stephdl January 29, 2026 08:31
Copilot stopped work on behalf of stephdl due to an error January 29, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants