Fix Loki-Metrics initialization race condition#47
Merged
DavidePrincipi merged 4 commits intomainfrom Jan 19, 2026
Merged
Conversation
Publish the Prometheus metrics endpoint configuration in Redis.
There was a problem hiding this comment.
Pull request overview
This PR resolves a configuration race condition during cluster initialization between Loki and Metrics modules by enabling the Metrics module to discover and scrape Loki's Prometheus metrics endpoint.
Changes:
- Adds anonymous access to Loki's /metrics endpoint via Traefik routing configuration
- Creates a provisioning script that publishes Loki's metrics endpoint to Redis for Metrics module discovery
- Implements the script in both create-module and update-module.d directories for initial setup and updates
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| imageroot/update-module.d/80provision_metrics | Symlink to provision script for module updates |
| imageroot/scripts/expandconfig-traefik | Adds unauthenticated /metrics route with priority 100 |
| imageroot/actions/create-module/80provision_metrics | Publishes metrics endpoint configuration to Redis |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Loki instances may be on worker nodes too.
Amygos
approved these changes
Jan 16, 2026
gsanchietti
approved these changes
Jan 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the Metrics module to access Loki metrics like other applications:
This change resolves a config race condition during cluster initialization between Loki and Metrics.
See also NethServer/ns8-metrics#45
Refs NethServer/dev#7780