Add missing translation keys for MTU/MSS Fix validation errors #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: gsanchietti <[email protected]>
Copilot
AI
changed the title
[WIP] Update mtu and mssfix options based on review feedback
Add missing translation keys for MTU/MSS Fix validation errors
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from #131 where validation error messages referenced undefined translation keys.
Changes:
error.tun_mtu_minanderror.mssfix_mintoui/public/i18n/en/translation.jsonThe Settings.vue validation code was already checking for minimum values (576 for TUN MTU, 0 for MSS Fix) but the corresponding translation strings were missing, causing runtime errors when validation failed.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.