Skip to content

Conversation

@gsanchietti
Copy link
Member

@gsanchietti gsanchietti commented Nov 21, 2025

This pull request adds support for configuring OpenVPN MTU (tun_mtu) and MSSFIX (mssfix) settings through both backend and frontend, allowing users to customize these values via the UI and have them properly validated and persisted. The changes ensure these parameters are included in configuration files, validated in both backend and frontend, and exposed in the settings interface.

Backend configuration and validation:

  • Added tun_mtu and mssfix fields to the backend configuration dictionaries and ensured they are written to config.env for OpenVPN settings. [1] [2]
  • Updated backend input/output validation schemas to include tun_mtu and mssfix as integer fields with defaults and minimum values. [1] [2] [3]

Frontend UI and validation:

  • Added input fields for tun_mtu and mssfix to the settings page, including tooltips, helper text, and error messages.
  • Integrated tun_mtu and mssfix into the frontend data model, form validation, and configuration submission logic, including minimum value checks (576 for MTU, 0 for MSSFIX). [1] [2] [3] [4] [5] [6]

Screenshots

image image image

Added also a tooltip for Maxmind:
image

@gsanchietti gsanchietti force-pushed the mtu_option branch 3 times, most recently from db241c5 to b162c59 Compare November 24, 2025 10:20
@gsanchietti gsanchietti marked this pull request as ready for review November 24, 2025 10:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring OpenVPN MTU (tun_mtu) and MSSFIX (mssfix) settings, enabling users to customize these network parameters through both the backend API and frontend UI. The changes ensure proper validation, persistence, and user interface integration for these OpenVPN network tuning parameters.

Key changes:

  • Added tun_mtu and mssfix configuration fields with default values (1500 and 1450 respectively) across backend and frontend
  • Implemented frontend validation requiring minimum values of 576 for MTU and 0 for MSSFIX
  • Extended UI with input fields, tooltips, and helper text for the new parameters
  • Bumped version to 2.2.0

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
ui/src/views/Settings.vue Added input fields for tun_mtu and mssfix with validation logic, data model integration, and MaxMind tooltip
ui/public/i18n/en/translation.json Added English translations for labels, helper text, and tooltips for the new MTU and MSSFIX fields
imageroot/actions/get-configuration/validate-output.json Updated output schema example to include tun_mtu and mssfix fields
imageroot/actions/get-configuration/20read Added default values for tun_mtu (1500) and mssfix (1450) in initial configuration
imageroot/actions/configure-module/validate-input.json Added validation schema for tun_mtu and mssfix as integer fields with minimum 0 and defaults
imageroot/actions/configure-module/20configure Implemented writing tun_mtu and mssfix values to config.env as OVPN_TUN_MTU and OVPN_MSSFIX
build-images.sh Bumped controller version from 2.1.1 to 2.2.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI commented Nov 24, 2025

@gsanchietti I've opened a new pull request, #136, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 24, 2025

@gsanchietti I've opened a new pull request, #137, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 24, 2025

@gsanchietti I've opened a new pull request, #138, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 24, 2025

@gsanchietti I've opened a new pull request, #139, to work on those changes. Once the pull request is ready, I'll request review from you.

Copy link

Copilot AI commented Nov 24, 2025

@gsanchietti I've opened a new pull request, #140, to work on those changes. Once the pull request is ready, I'll request review from you.

@Tbaile
Copy link
Contributor

Tbaile commented Nov 24, 2025

And here I thought that you disliked being pinged for PRs, github already emailed me 25 times for this PR 😬
Add me to reviewers when the bots adjust the code

@Tbaile Tbaile removed their request for review November 24, 2025 10:44
@gsanchietti gsanchietti force-pushed the mtu_option branch 2 times, most recently from a1ee16b to dd8ce64 Compare November 24, 2025 11:45
Fix regression introduced by a901e69
Copy link
Contributor

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Frontend checks look overkill, but go with it

@Tbaile Tbaile linked an issue Nov 25, 2025 that may be closed by this pull request
@gsanchietti gsanchietti merged commit b1b253b into main Nov 25, 2025
5 of 6 checks passed
@gsanchietti gsanchietti deleted the mtu_option branch November 25, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NethSecurity Controller: Add MTU option

3 participants