-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add mtu and mssfix options #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
db241c5 to
b162c59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for configuring OpenVPN MTU (tun_mtu) and MSSFIX (mssfix) settings, enabling users to customize these network parameters through both the backend API and frontend UI. The changes ensure proper validation, persistence, and user interface integration for these OpenVPN network tuning parameters.
Key changes:
- Added
tun_mtuandmssfixconfiguration fields with default values (1500 and 1450 respectively) across backend and frontend - Implemented frontend validation requiring minimum values of 576 for MTU and 0 for MSSFIX
- Extended UI with input fields, tooltips, and helper text for the new parameters
- Bumped version to 2.2.0
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| ui/src/views/Settings.vue | Added input fields for tun_mtu and mssfix with validation logic, data model integration, and MaxMind tooltip |
| ui/public/i18n/en/translation.json | Added English translations for labels, helper text, and tooltips for the new MTU and MSSFIX fields |
| imageroot/actions/get-configuration/validate-output.json | Updated output schema example to include tun_mtu and mssfix fields |
| imageroot/actions/get-configuration/20read | Added default values for tun_mtu (1500) and mssfix (1450) in initial configuration |
| imageroot/actions/configure-module/validate-input.json | Added validation schema for tun_mtu and mssfix as integer fields with minimum 0 and defaults |
| imageroot/actions/configure-module/20configure | Implemented writing tun_mtu and mssfix values to config.env as OVPN_TUN_MTU and OVPN_MSSFIX |
| build-images.sh | Bumped controller version from 2.1.1 to 2.2.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@gsanchietti I've opened a new pull request, #136, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gsanchietti I've opened a new pull request, #137, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gsanchietti I've opened a new pull request, #138, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gsanchietti I've opened a new pull request, #139, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
@gsanchietti I've opened a new pull request, #140, to work on those changes. Once the pull request is ready, I'll request review from you. |
|
And here I thought that you disliked being pinged for PRs, github already emailed me 25 times for this PR 😬 |
a1ee16b to
dd8ce64
Compare
dd8ce64 to
ae19e1f
Compare
Fix regression introduced by a901e69
Tbaile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend checks look overkill, but go with it
This pull request adds support for configuring OpenVPN MTU (
tun_mtu) and MSSFIX (mssfix) settings through both backend and frontend, allowing users to customize these values via the UI and have them properly validated and persisted. The changes ensure these parameters are included in configuration files, validated in both backend and frontend, and exposed in the settings interface.Backend configuration and validation:
tun_mtuandmssfixfields to the backend configuration dictionaries and ensured they are written toconfig.envfor OpenVPN settings. [1] [2]tun_mtuandmssfixas integer fields with defaults and minimum values. [1] [2] [3]Frontend UI and validation:
tun_mtuandmssfixto the settings page, including tooltips, helper text, and error messages.tun_mtuandmssfixinto the frontend data model, form validation, and configuration submission logic, including minimum value checks (576 for MTU, 0 for MSSFIX). [1] [2] [3] [4] [5] [6]Screenshots
Added also a tooltip for Maxmind:
