Skip to content

Conversation

Copy link

Copilot AI commented Nov 24, 2025

The validation logic in Settings.vue references error.tun_mtu_min and error.mssfix_min translation keys that were not defined, causing missing error messages when validation fails.

Changes:

  • Added tun_mtu_min and mssfix_min error keys to all translation files (en, it, es)
  • Error messages follow existing validation pattern for minimum value constraints
// Settings.vue validation now displays proper error messages
if (parseInt(this.tun_mtu) < 576) {
  this.error.tun_mtu = this.$t("error.tun_mtu_min");  // Now resolves correctly
}

if (parseInt(this.mssfix) < 0) {
  this.error.mssfix = this.$t("error.mssfix_min");  // Now resolves correctly
}

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copy link
Author

Copilot AI commented Nov 24, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • registry.npmmirror.com
    • Triggering command: /usr/local/bin/node node /usr/local/bin/yarn install (dns block)
    • Triggering command: /usr/local/bin/node node /usr/local/bin/npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Add implementation updates for mtu and mssfix options Add missing translation keys for MTU and MSS Fix validation errors Nov 24, 2025
Copilot AI requested a review from gsanchietti November 24, 2025 10:49
@gsanchietti gsanchietti marked this pull request as ready for review November 24, 2025 10:54
@gsanchietti gsanchietti merged commit e44facd into mtu_option Nov 24, 2025
@gsanchietti gsanchietti deleted the copilot/sub-pr-131-again branch November 24, 2025 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants