Restore Taiko FCU timestamp validation allowing equal timestamps#10810
Open
jmadibekov wants to merge 3 commits intomasterfrom
Open
Restore Taiko FCU timestamp validation allowing equal timestamps#10810jmadibekov wants to merge 3 commits intomasterfrom
jmadibekov wants to merge 3 commits intomasterfrom
Conversation
…amps Commit 195829e (Bal devnet 2) renamed IsPayloadAttributesTimestampValid, removed the virtual keyword, and deleted TaikoForkchoiceUpdatedHandler's override that allowed equal timestamps. This broke Taiko Pacaya where multiple L2 blocks derived from a single L1 block share the same timestamp.
jmadibekov
requested review from
LukaszRozmej,
Marchhill,
MarekM25,
benaadams,
dipkakwani,
flcl42 and
smartprogrammer93
as code owners
github-actions
bot
added
bug fix + reliability
taiko
jmadibekov
changed the title
Contributor
|
@copilot implement the following suggestion to this PR::
|
16 tasks
Contributor
|
@smartprogrammer93 I've opened a new pull request, #10811, to work on those changes. Once the pull request is ready, I'll request review from you. |
smartprogrammer93
approved these changes
Mar 12, 2026
Job-level timeout 45m → 20m, add step-level 15m timeout on the test step so timeouts show as failures instead of cancellations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GetMinRequiredTimestampvirtual method toForkchoiceUpdatedHandler(returnsTimestamp + 1by default for strict increase)TaikoForkchoiceUpdatedHandleras a one-liner returningTimestamp(allowing equal timestamps)timeout-minutesfrom 45 to 20 inci-surge.ymlandci-taiko.yml, add step-level 15m timeout on the test step so timeouts surface as failures instead of cancellationsPR #10325 renamed
IsPayloadAttributesTimestampValid→ArePayloadAttributesTimestampAndSlotNumberValid, removedvirtual, and deleted the Taiko override. In Taiko Pacaya, multiple L2 blocks can be derived from a single L1 block sharing the same L1 anchor timestamp, so equal timestamps must be allowed.Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Added 3 test cases in
TaikoEngineApiTestsverifying equal timestamps are accepted, greater timestamps are accepted, and lesser timestamps are rejected.Integration tests passed on this PR:
Documentation
Requires documentation update
Requires explanation in Release Notes