Restore Taiko FCU timestamp validation allowing equal timestamps#10811
Closed
Copilot wants to merge 1 commit intojmadibekov/fix-taiko-fcu-timestamp-validationfrom
Closed
Restore Taiko FCU timestamp validation allowing equal timestamps#10811Copilot wants to merge 1 commit intojmadibekov/fix-taiko-fcu-timestamp-validationfrom
Copilot wants to merge 1 commit intojmadibekov/fix-taiko-fcu-timestamp-validationfrom
Conversation
5 tasks
Copilot
AI
changed the title
[WIP] Restore timestamp validation allowing equal timestamps
Restore Taiko FCU timestamp validation allowing equal timestamps
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Taiko Pacaya allows multiple L2 blocks derived from a single L1 block, all sharing the same L1 anchor timestamp — so equal timestamps must be accepted. This was broken in #10325, which renamed
ArePayloadAttributesTimestampAndSlotNumberValid, droppedvirtual, and deleted the Taiko override.Changes
protected virtual ulong GetMinRequiredTimestamp(Block newHeadBlock) => newHeadBlock.Timestamp + 1;toForkchoiceUpdatedHandler, used by the timestamp validation logicArePayloadAttributesTimestampAndSlotNumberValidis now non-virtual (delegates threshold toGetMinRequiredTimestamp)TaikoForkchoiceUpdatedHandleroverrides only the one-liner:=> newHeadBlock.Timestamp(allowing>=instead of>)Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Added 3 test cases in
TaikoEngineApiTests: equal timestamp accepted, greater timestamp accepted, lesser timestamp rejected.Documentation
Requires documentation update
Requires explanation in Release Notes
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.