Skip to content

fix: handle null ExcessBlobGas in EIP-7918 calculation #9888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
strmfos wants to merge 2 commits into
base: master
Choose a base branch
from
+22 −1
Open

fix: handle null ExcessBlobGas in EIP-7918 calculation #9888

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732cda3
fix: handle null ExcessBlobGas in EIP-7918 calculation
strmfos Dec 5, 2025
02465eb
add test
strmfos Dec 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/Nethermind/Nethermind.Evm.Test/Eip7918Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,4 +91,25 @@ private static IEnumerable<TestCaseData> GenerateTestCases()
(ulong)baseFeePerGas + 100,
expectedExcessBlobGas);
}

[Test]
public void Excess_blob_gas_with_null_ExcessBlobGas_applies_floor_correctly()
{
IReleaseSpec spec = Osaka.Instance;
int blobsUsed = (int)spec.TargetBlobCount + 1;

// null ExcessBlobGas treated as 0, floor applies
BlockHeader parentHeader = Build.A.BlockHeader
.WithBlobGasUsed(BlobGasCalculator.CalculateBlobGas(blobsUsed))
.WithExcessBlobGas(null)
.WithBaseFee(1_000_000_000)
.TestObject;

ulong? result = BlobGasCalculator.CalculateExcessBlobGas(parentHeader, spec);

ulong blobGasUsed = BlobGasCalculator.CalculateBlobGas(blobsUsed);
ulong expected = blobGasUsed * (spec.MaxBlobCount - spec.TargetBlobCount) / spec.MaxBlobCount;

Assert.That(result, Is.EqualTo(expected));
}
}
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Evm/BlobGasCalculator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ static bool FakeExponentialOverflow(UInt256 factor, UInt256 num, UInt256 denomin

if (releaseSpec.IsEip7918Enabled)
{
TryCalculateFeePerBlobGas(parentBlockHeader, releaseSpec.BlobBaseFeeUpdateFraction, out UInt256 feePerBlobGas);
TryCalculateFeePerBlobGas(excessBlobGas, releaseSpec.BlobBaseFeeUpdateFraction, out UInt256 feePerBlobGas);
UInt256 floorCost = Eip7918Constants.BlobBaseCost * parentBlockHeader.BaseFeePerGas;
UInt256 targetCost = Eip4844Constants.GasPerBlob * feePerBlobGas;

Expand Down