-
Notifications
You must be signed in to change notification settings - Fork 32
merging master into experiimental #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dellams
wants to merge
37
commits into
Experimental
Choose a base branch
from
master
base: Experimental
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
3df3fac
- Can now search holons by parentId and filter by meta data.
dellams 5aee40a
Multiple bug fixes for NFTs in STAR CLI.
dellams 39a00f0
Merge branch 'Experimental' into master
dellams 6e06bdd
Fixing build errors
dellams c6fe6cf
Fixing build issues
dellams c5bab2e
build fixed
dellams 7cf7bab
Lots more done! :)
dellams 3770957
Added STAR Demo Series Summary Doc
dellams b2425d4
Updated Docs & fixing more issues in providers.
dellams 434d0c9
Merge pull request #352 from NextGenSoftwareUK/Experimental
dellams 59e54d8
More fixes to the providers and STAR CLI & NFTs
dellams b6cf8d8
Got STAR building again.
dellams 9a2f5a6
STAR CLI Improvements
dellams 572c684
- Added support welcome message for donations etc to STAR CLI.
dellams 82f1cf4
- Fixed bugs in ShowMetaData, GetMetaData & ManageMetaData methods in…
dellams 6f8563f
Update Grants & Case Studies with OpenServ entry
dellams 91aa340
Update README to remove completion indicators
dellams 8fc57c1
Update README to streamline architecture content
dellams 18cd81e
Add files via upload
dellams c529063
Add link to OASIS Torus architecture diagram
dellams 7a048ce
Add image tag for OASIS Torus architecture
dellams e38e039
Add OASIS Architecture diagram to README
dellams da0fe3a
Fix OASIS Architecture image link
dellams 9b4d295
Add STAR ODK/CLI to Phase 1 features
dellams 01429ab
Changed the STARNETCategory to STARHolonType for STARHolonManager.
dellams 449cfd1
Merge branch 'master' of https://github.com/NextGenSoftwareUK/OASIS
dellams 2ad3bd4
- Removed IGetWeb3WalletBalanceRequest request param from GenerateKey…
dellams ab964b7
- Fixed a bug in CreateWalletWithoutSaving method in WalletManager i…
dellams a79cbcb
- Fixed a bug in LoadProviderWalletsForAvatarByIdAsync & SaveProvider…
dellams 58ce198
LOTS of bugs fixed mostly in the Wallet API/Manager but also in ONODE…
dellams 37aa201
- Added AvatarId back into IProviderWallet in OASIS.API.Core.
dellams 98073f3
- Fixed bugs in the OASIS Bridge
dellams f56f511
- Lots of bugs fixed for OAPP Generation, NFTs and more! :)
dellams 196d7b3
- Fixed a bug in MintAndPlaceWeb4GeoNFTAsync in NFTManager in OASIS.O…
dellams 3c6101f
- Fixed bugs in InstalledGeoNFT, InstalledGeoNFTCollection, Installed…
dellams 84da1f8
- Added WaitTillNFTBurnt, WaitForNFTToBurnInSeconds & AttemptToBurnEv…
dellams 8aab0ef
- Fixed a bug in DeleteAsync in STARNETManagerBase in OASIS.API.ONODE…
dellams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
OASIS Architecture/NextGenSoftware.OASIS.API.Core/Interfaces/NFT/IWeb3NFT.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 4 additions & 1 deletion
5
OASIS Architecture/NextGenSoftware.OASIS.API.Core/Interfaces/Search/ISearchParams.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Race condition in lazy-initialized provider properties returns null
The newly uncommented provider properties (
EOSIO,Ethereum,Telos,ActivityPub) useTask.Runto asynchronously initialize the backing field but immediately return the field value without awaiting completion. On first access, this returns null because the async registration hasn't finished yet. The fire-and-forget pattern means callers receive null and subsequent accesses may still race with the ongoing initialization.Additional Locations (2)
Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L133-L153](https://github.com/NextGenSoftwareUK/OASIS/blob/c5bab2e5a1b116de1e7fc44002ce21042baa01d5/Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L133-L153)Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L217-L237](https://github.com/NextGenSoftwareUK/OASIS/blob/c5bab2e5a1b116de1e7fc44002ce21042baa01d5/Native EndPoint/NextGenSoftware.OASIS.API.Native.Integrated.EndPoint/APIs/WEB4 OASIS API/OASISProviders.cs#L217-L237)