fixes for windows oF 0.12.0 #2
Conversation
|
HI @funatsufumiya, thank you for the pull request and using the addon :) I have been working on updating the ofxSvg to function similar to ofxSvgParser. I noticed some issues with Thank you for pointing out this issue! |
|
Thank you for your quick response. Sorry for my misunderstanding of |
|
@funatsufumiya you read the README correctly! 😊 It should be updated to work with 12.0; I don't use Windows often so thank you for pointing it out. Can you update this PR to use the Optional class in Line 19 in 12922ea And comment out / remove the optional include here: ofxSvgParser/src/ofxSvgCss.cpp Line 13 in 12922ea |
src/ofxSvgParser.cpp
Outdated
| @@ -784,7 +785,7 @@ void Parser::_parsePath( ofXml& tnode, std::shared_ptr<Path> aSvgPath ) { | |||
|
|
|||
| bool bRelative = false; | |||
| std::vector<glm::vec3> npositions= {glm::vec3(0.f, 0.f, 0.f)}; | |||
| std::optional<ofPath::Command::Type> ctype; | |||
| boost::optional<ofPath::Command::Type> ctype; | |||
There was a problem hiding this comment.
Can you try updating this to
CssClass::Optional<ofPath::Command::Type> ctype;
Thank you!
There was a problem hiding this comment.
OK. I think this PR is sill valuable for windows 0.12.0 oF users, so I'll create another PR for this (as for 0.12.1.)
There was a problem hiding this comment.
Created #3. I tested it with oF v0.12.1 both macOS / Windows.
There was a problem hiding this comment.
CssClass::Optional<ofPath::Command::Type> ctype;
Sorry for having miss-checked this. I also test this.
Some part didn't work on windows oF 0.12.0. This fixes it. (Confirmed also working on macOS.)
In particular, please note that
std::optionalis not available in the default environment generated by oF 0.12.0 Project Generator on Windows.Please consider carefully whether to merge.