Skip to content

fixes for windows oF 0.12.0 #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
funatsufumiya wants to merge 2 commits into from
Closed

fixes for windows oF 0.12.0 #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31c8de
fix: for windows oF 0.12.0
funatsufumiya Aug 25, 2025
3a8d7a3
fix: replace boost::optional into CssClass::Optional
funatsufumiya Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ofxSvgElements.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ class Image : public Element {
virtual void draw() override;
glm::vec2 getAnchorPointForPercent( float ax, float ay );

std::string getFilePath() { return filepath; }
std::string getFilePath() { return filepath.string(); }

void setColor( ofColor aColor ) {
color = aColor;
Expand Down
7 changes: 4 additions & 3 deletions src/ofxSvgParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "ofUtils.h"
#include <regex>
#include "ofGraphics.h"
#include "boost/optional.hpp"

using namespace ofx::svg;
using std::string;
Expand All @@ -27,7 +28,7 @@ bool Parser::load( of::filesystem::path aPathToSvg ) {
ofFile mainXmlFile( aPathToSvg, ofFile::ReadOnly );
ofBuffer tMainXmlBuffer( mainXmlFile );

svgPath = aPathToSvg;
svgPath = aPathToSvg.string();
folderPath = ofFilePath::getEnclosingDirectory( aPathToSvg, false );

ofXml xml;
Expand Down Expand Up @@ -784,7 +785,7 @@ void Parser::_parsePath( ofXml& tnode, std::shared_ptr<Path> aSvgPath ) {

bool bRelative = false;
std::vector<glm::vec3> npositions= {glm::vec3(0.f, 0.f, 0.f)};
std::optional<ofPath::Command::Type> ctype;
boost::optional<ofPath::Command::Type> ctype;
Copy link
Owner

@NickHardeman NickHardeman Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try updating this to
CssClass::Optional<ofPath::Command::Type> ctype;
Thank you!

Copy link
Contributor Author

@funatsufumiya funatsufumiya Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I think this PR is sill valuable for windows 0.12.0 oF users, so I'll create another PR for this (as for 0.12.1.)

Copy link
Contributor Author

@funatsufumiya funatsufumiya Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #3. I tested it with oF v0.12.1 both macOS / Windows.

Copy link
Contributor Author

@funatsufumiya funatsufumiya Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CssClass::Optional<ofPath::Command::Type> ctype;

Sorry for having miss-checked this. I also test this.

Copy link
Contributor Author

@funatsufumiya funatsufumiya Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on macOS/Windows oF 0.12.0 / 0.12.1.
Now both #2 and #3 is the same one. So I'll close #2.


// check if we are looking for a position
if( cchar == 'm' || cchar == 'M' ) {
Expand Down Expand Up @@ -860,7 +861,7 @@ void Parser::_parsePath( ofXml& tnode, std::shared_ptr<Path> aSvgPath ) {
// }
}

if( ctype.has_value() ) {
if( ctype != boost::none ) {

// for( auto& np : npositions ) {
// ofLogNotice(moduleName()) << cchar << " position: " << np;
Expand Down