Skip to content

Fix duo authorization without preferred device#479

Open
yermalov-here wants to merge 1 commit intoNike-Inc:masterfrom
yermalov-here:fix-duo-no-preferred-device
Open

Fix duo authorization without preferred device#479
yermalov-here wants to merge 1 commit intoNike-Inc:masterfrom
yermalov-here:fix-duo-no-preferred-device

Conversation

@yermalov-here
Copy link

@yermalov-here yermalov-here commented Sep 26, 2024

Description

Fixes handling of the case when there is no preferred_device input in the duo login form.

Related Issue

#478

Motivation and Context

Fixes authorization for users with Duo hardware tokens.

How Has This Been Tested?

Added a test with a new fixture login-form that is based on the actual service response.
Tested the fixed case locally by running the tool.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yermalov-here
Copy link
Author

@epierce, could you please take a look at this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments