Skip to content

Fix duo authorization without preferred device #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yermalov-here wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix duo authorization without preferred device #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion gimme_aws_creds/duo_universal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,8 @@ def _get_duo_universal_login_form_data(self, plugin_form_response):

@staticmethod
def _find_device_to_use(doc):
device = doc.find('.//input[@name="preferred_device"]').get('value')
preferred_device_block = doc.find('.//input[@name="preferred_device"]')
device = preferred_device_block.get('value') if preferred_device_block is not None else None
if device is None or device == '':
device = doc.find('.//select[@name="device"]/option').get('value')
return device
Expand Down
Loading