Merged
Conversation
350bc06 to
06ff0df
Compare
Ericson2314
approved these changes
Jan 23, 2026
Member
|
This bump has an issue related to s3 stats. I just noticed that Nix removed getS3Stats in @lovesegfault PR which replaced the S3 implementation with curl: NixOS/nix#13752 We still use this here in the old queue runner: https://github.com/NixOS/hydra/blob/master/src/hydra-queue-runner/hydra-queue-runner.cc#L694-L720 CI did not catch this because the define This means we currently dont have S3 statistics in the upstream hydra, see https://hydra.nixos.org/queue_runner_status CC @mweinelt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.