-
-
Notifications
You must be signed in to change notification settings - Fork 782
Add ThinkPad T14 Intel Gen 6 support #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Add T14 Gen 6 hardware profile with Lunar Lake CPU/GPU support - Include Intel Arc graphics and modern kernel requirements - Update README.md and flake.nix with new module entries - Follow CONTRIBUTING.md guidelines for profile structure
- Add acpi_backlight=native for proper brightness control - Include touchpad fix for click registration issues - Disable throttled service for modern Intel power management - Mark additions with TODO comments seeking community feedback
Hardware profiles should not include lock files to maintain compatibility across different nixpkgs versions
I reviewed the error, and the component that the
Cheers. |
Enable fprintd service for fingerprint authentication on T14 Gen 6. This allows users to enroll and use fingerprint login after running 'sudo fprintd-enroll $USER'.
Add PAM configuration to enable fingerprint authentication for login, sudo, su, and xscreensaver. This makes the fingerprint interface available in GNOME Settings and enables fingerprint unlock.
Remove PAM fingerprint authentication from hardware profile to avoid breaking GDM password login as described in nixpkgs#171136. Users should configure PAM in their host config for safe fingerprint auth.
Add comprehensive comments explaining how to configure PAM services for complete fingerprint authentication in GNOME, including warnings about potential login issues and step-by-step setup instructions.
flake.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Note that there is an issue with flake.lock
not being synced with the actual flake.nix
that we have, which I’m trying to address on #1570.
At any rate, I’d recommend removing flake.lock
from the scope of this PR (to keep things orthogonal, that is).
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did end up removing the lock file previously. So that is taken care of. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, that doesn't fly, I'm afraid. If this PR gets accepted, the project as a whole will end up without the flake.lock
file. We don't want that. What I propose is that you drop the edit to flake.lock
altogether. The resulting PR should then contain no mention of flake.lock
. And, when the previous fix is accepted by the project, this PR will have no conflicts as a bonus.
My suggestion would be that you rewrite the history of your PR, and when the changes to flake.lock
are gone, then force-push to your branch. Let me know if you need and/or want assistance with this.
Hint: git rebase --interactive
is your friend.
Thanks!
(Sorry, I missed this comment before.) The formatter has been recently moved (a7600ce) to the nixos-hardware/.github/workflows/test.yml Line 14 in 26ed7a0
So, just run Hope that it helps! Happy hacking, |
Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Thanks for the tip! It ran clean locally after two runs. I have now committed that change as well. |
Glad to be of service! |
Hardware Profile
Adds support for Lenovo ThinkPad T14 Intel Gen 6 with Intel Core Ultra processors (Lunar Lake architecture).
Changes
Hardware Tested
Feedback Requested
The kernel parameters and throttled service settings are marked with TODO comments as they're based on common ThinkPad patterns. Feedback from other T14 Gen 6 users would help validate these optimizations.
Test Plan