-
-
Notifications
You must be signed in to change notification settings - Fork 782
Add ThinkPad T14 Intel Gen 6 support #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bashfulrobot
wants to merge
9
commits into
NixOS:master
Choose a base branch
from
bashfulrobot:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bbb1f26
feat: Add ThinkPad T14 Intel Gen 6 support
bashfulrobot 3394443
improve: Enhance T14 Intel Gen 6 with common ThinkPad optimizations
bashfulrobot 16b37dd
fix: Remove flake.lock file
bashfulrobot 69b5d17
feat: ✨ add fingerprint support to ThinkPad T14 Intel Gen 6
bashfulrobot 1369abb
feat: ✨ enable PAM fingerprint authentication for T14 Gen 6
bashfulrobot 8a715bb
fix: remove PAM fingerprint config to prevent login issues
bashfulrobot fce75d6
docs: 📝 add PAM fingerprint configuration guidance for T14 Gen 6
bashfulrobot ee70c10
refactor: clean up PAM configuration comments formatting
bashfulrobot b8256fd
fix: restore flake.lock from upstream
bashfulrobot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { lib, pkgs, ... }: | ||
|
|
||
| { | ||
| imports = [ | ||
| ../. | ||
| ../../../../common/cpu/intel | ||
| ../../../../common/gpu/intel | ||
| ]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| { | ||
| lib, | ||
| pkgs, | ||
| config, | ||
| ... | ||
| }: | ||
|
|
||
| { | ||
| imports = [ | ||
| ../../. | ||
| ../../../../../common/cpu/intel/lunar-lake | ||
| ]; | ||
|
|
||
| # T14 Gen 6 uses Intel Core Ultra processors (Lunar Lake architecture) | ||
| # with integrated Intel Arc graphics | ||
| # The lunar-lake module already includes appropriate GPU support | ||
|
|
||
| # Ensure modern kernel for full Lunar Lake support | ||
| boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "6.8") pkgs.linuxPackages_latest; | ||
|
|
||
| # TODO: Looking for feedback on these kernel parameters for T14 Gen 6 | ||
| # Force use of the thinkpad_acpi driver for backlight control | ||
| # This allows the backlight save/load systemd service to work | ||
| boot.kernelParams = [ | ||
| "acpi_backlight=native" | ||
| # TODO: Looking for feedback - touchpad fix needed for proper click registration on some T14 models | ||
| "psmouse.synaptics_intertouch=0" | ||
| ]; | ||
|
|
||
| # TODO: Looking for feedback - modern Intel CPUs don't typically need throttled service | ||
| # which can interfere with newer power management on Lunar Lake | ||
| services.throttled.enable = lib.mkDefault false; | ||
|
|
||
| # Enable fingerprint reader support | ||
| # NOTE: PAM configuration should be done in host config to avoid login issues | ||
| # See: https://github.com/NixOS/nixpkgs/issues/171136 | ||
| services.fprintd.enable = lib.mkDefault true; | ||
|
|
||
| # For complete fingerprint authentication in GNOME, add the following to your host config: | ||
| # | ||
| # security.pam.services = { | ||
| # # Enable fingerprint authentication for sudo | ||
| # sudo.fprintAuth = lib.mkDefault true; | ||
| # | ||
| # # Enable fingerprint authentication for su | ||
| # su.fprintAuth = lib.mkDefault true; | ||
| # | ||
| # # Enable fingerprint authentication for screen unlock | ||
| # xscreensaver.fprintAuth = lib.mkDefault true; | ||
| # | ||
| # # WARNING: login.fprintAuth may break GDM password authentication | ||
| # # Only enable if you understand the risks: | ||
| # # login.fprintAuth = lib.mkDefault true; | ||
| # }; | ||
| # | ||
| # After configuration: | ||
| # 1. Rebuild your system | ||
| # 2. Enroll fingerprint: sudo fprintd-enroll $USER | ||
| # 3. Test sudo and screen unlock with fingerprint | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!
Note that there is an issue with
flake.locknot being synced with the actualflake.nixthat we have, which I’m trying to address on #1570.At any rate, I’d recommend removing
flake.lockfrom the scope of this PR (to keep things orthogonal, that is).Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did end up removing the lock file previously. So that is taken care of. 👍
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Um, that doesn't fly, I'm afraid. If this PR gets accepted, the project as a whole will end up without the
flake.lockfile. We don't want that. What I propose is that you drop the edit toflake.lockaltogether. The resulting PR should then contain no mention offlake.lock. And, when the previous fix is accepted by the project, this PR will have no conflicts as a bonus.My suggestion would be that you rewrite the history of your PR, and when the changes to
flake.lockare gone, then force-push to your branch. Let me know if you need and/or want assistance with this.Hint:
git rebase --interactiveis your friend.Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad! I thought that lock came in on my local test builds. 😨
I have restored it from the main repo. And it no longer shows in the affected files. Should be good there!
Cheers.