Skip to content

Add ThinkPad T14 Intel Gen 6 support #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add ThinkPad T14 Intel Gen 6 support #1572

wants to merge 9 commits into from

Conversation

bashfulrobot
Copy link
Contributor

Hardware Profile

Adds support for Lenovo ThinkPad T14 Intel Gen 6 with Intel Core Ultra processors (Lunar Lake architecture).

Changes

  • CPU/GPU Support: Uses module for Intel Core Ultra 5/7 processors with Intel Arc integrated graphics
  • Kernel Requirements: Ensures kernel 6.8+ for full Lunar Lake support
  • Hardware Optimizations:
    • for ThinkPad brightness control
    • for touchpad click registration
    • Disables service for modern Intel power management
  • Module Structure: Added both base Intel T14 profile and Gen 6 specific profile
  • Documentation: Updated README.md table and flake.nix entries

Hardware Tested

  • Intel Core Ultra 7 268V processor
  • Intel Arc Graphics 130V/140V
  • All hardware functionality verified working
  • Kernel 6.16.0 with xe driver loaded successfully

Feedback Requested

The kernel parameters and throttled service settings are marked with TODO comments as they're based on common ThinkPad patterns. Feedback from other T14 Gen 6 users would help validate these optimizations.

Test Plan

  • Graphics acceleration working (Mesa Intel Graphics LNL)
  • xe driver loading correctly
  • Kernel 6.8+ requirement met
  • Hardware detection functional
  • Community testing of brightness keys
  • Community testing of touchpad behavior
  • Community validation of power management settings

@bashfulrobot
feat: Add ThinkPad T14 Intel Gen 6 support
bbb1f26 
- Add T14 Gen 6 hardware profile with Lunar Lake CPU/GPU support
- Include Intel Arc graphics and modern kernel requirements
- Update README.md and flake.nix with new module entries
- Follow CONTRIBUTING.md guidelines for profile structure
@bashfulrobot
improve: Enhance T14 Intel Gen 6 with common ThinkPad optimizations
3394443 
- Add acpi_backlight=native for proper brightness control
- Include touchpad fix for click registration issues
- Disable throttled service for modern Intel power management
- Mark additions with TODO comments seeking community feedback
@bashfulrobot
fix: Remove flake.lock file
16b37dd 
Hardware profiles should not include lock files to maintain compatibility
across different nixpkgs versions
@bashfulrobot
Copy link
Contributor Author

bashfulrobot commented Aug 8, 2025 •
edited
Loading

I reviewed the error, and the component that the nix fmt is complaining about also does not exist in your current flake. Can I ignore that? Or if there is something I need to do. Please let me know. I am currently running this code from my repo on my laptop. Feel free to let me know if there is anything else you need. Appreciate your time.

 nix fmt ..                nixos-hardware on  master took 6m5s error: flake 'git+file:///home/dustin/dev/nix/nixos-hardware' does not provide attribute 'formatter.x86_64-linux'

Cheers.

@bashfulrobot
feat: ✨ add fingerprint support to ThinkPad T14 Intel Gen 6
69b5d17 
Enable fprintd service for fingerprint authentication on T14 Gen 6.
This allows users to enroll and use fingerprint login after running
'sudo fprintd-enroll $USER'.
@bashfulrobot
feat: ✨ enable PAM fingerprint authentication for T14 Gen 6
1369abb 
Add PAM configuration to enable fingerprint authentication for login,
sudo, su, and xscreensaver. This makes the fingerprint interface
available in GNOME Settings and enables fingerprint unlock.
@bashfulrobot
fix: remove PAM fingerprint config to prevent login issues
8a715bb 
Remove PAM fingerprint authentication from hardware profile to avoid
breaking GDM password login as described in nixpkgs#171136. Users
should configure PAM in their host config for safe fingerprint auth.
@bashfulrobot
docs: 📝 add PAM fingerprint configuration guidance for T14 Gen 6
fce75d6 
Add comprehensive comments explaining how to configure PAM services
for complete fingerprint authentication in GNOME, including warnings
about potential login issues and step-by-step setup instructions.
panchoh
panchoh reviewed Aug 10, 2025
View reviewed changes
@panchoh
Copy link

panchoh commented Aug 11, 2025 •
edited
Loading

I reviewed the error, and the component that the nix fmt is complaining about also does not exist in your current flake. Can I ignore that? Or if there is something I need to do. Please let me know. I am currently running this code from my repo on my laptop. Feel free to let me know if there is anything else you need. Appreciate your time.

 nix fmt ..                nixos-hardware on  master took 6m5s error: flake 'git+file:///home/dustin/dev/nix/nixos-hardware' does not provide attribute 'formatter.x86_64-linux'

Cheers.

(Sorry, I missed this comment before.)

The formatter has been recently moved (a7600ce) to the tests flake, so the GitHub Actions workflow enters the tests directory before running nix fmt:

nixos-hardware/.github/workflows/test.yml

Line 14 in 26ed7a0

- run: cd tests && nix fmt .. -- --fail-on-change

So, just run cd tests, and then run nix fmt .. -- --fail-on-change a couple of times until no errors are detected, and you are good to go. (Technically, the first pass will fix all the errors, but with the second pass, you get feedback that it won’t fail when run by the workflow.)

Hope that it helps!

Happy hacking,

@bashfulrobot
Copy link
Contributor Author

I reviewed the error, and the component that the nix fmt is complaining about also does not exist in your current flake. Can I ignore that? Or if there is something I need to do. Please let me know. I am currently running this code from my repo on my laptop. Feel free to let me know if there is anything else you need. Appreciate your time.

 nix fmt ..                nixos-hardware on  master took 6m5s error: flake 'git+file:///home/dustin/dev/nix/nixos-hardware' does not provide attribute 'formatter.x86_64-linux'

Cheers.

(Sorry, I missed this comment before.)

The formatter has been recently moved (a7600ce) to the tests flake, so the GitHub Actions workflow enters the tests directory before running nix fmt:

nixos-hardware/.github/workflows/test.yml

Line 14 in 26ed7a0

- run: cd tests && nix fmt .. -- --fail-on-change

So, just run cd tests, and then run nix fmt .. -- --fail-on-change a couple of times until no errors are detected, and you are good to go. (Tecnically, the first pass will fix all the errors, but with the second pass, you get feedback that it won’t fail when run by the workflow.)

Hope that it helps!

Happy hacking,

Thanks for the tip! It ran clean locally after two runs. I have now committed that change as well.

@panchoh
Copy link

panchoh commented Aug 12, 2025

Thanks for the tip! It ran clean locally after two runs. I have now committed that change as well.

Glad to be of service!

@bashfulrobot
Copy link
Contributor Author

Ok, the checks all passed! That's something. 🤣 is there anything else I need to do to get this PR in shape to get approved?

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@panchoh panchoh panchoh left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bashfulrobot @panchoh