Skip to content

plutosvg: init at 0.0.7#410666

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-yxtssnqvzxvl
Jun 1, 2025
Merged

plutosvg: init at 0.0.7#410666
Aleksanaa merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-yxtssnqvzxvl

Conversation

@marcin-serwin
Copy link
Contributor

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 25, 2025
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have to add two pkg-config validator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

validatePkgConfig checks whether .pc file is syntactically correct, while testMetaPkgConfig checks that it exports the modules listed in meta.pkgConfigModules.

Signed-off-by: Marcin Serwin <marcin@serwin.dev>
@PedroHLC
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 410666
Commit: f4af63c9866ab79fdf73c1f665d378dab178b78c


x86_64-linux

✅ 2 packages built:
  • plutosvg
  • plutosvg.dev

Copy link
Member

@PedroHLC PedroHLC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

files LGTM:

╭─pedrohlc at desktop in /home/pedrohlc/.cache/nixpkgs-review/pr-410666
╰─λ find results/plutosvg.dev-x86_64-linux/ -type f
results/plutosvg.dev-x86_64-linux/nix-support/propagated-build-inputs
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgTargets-release.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgConfigVersion.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgConfig.cmake
results/plutosvg.dev-x86_64-linux/lib/cmake/plutosvg/plutosvgTargets.cmake
results/plutosvg.dev-x86_64-linux/lib/pkgconfig/plutosvg.pc
results/plutosvg.dev-x86_64-linux/include/plutosvg/plutosvg.h
results/plutosvg.dev-x86_64-linux/include/plutosvg/plutosvg-ft.h
╭─pedrohlc at desktop in /home/pedrohlc/.cache/nixpkgs-review/pr-410666
╰─λ find results/plutosvg-x86_64-linux/ -type f
results/plutosvg-x86_64-linux/lib/libplutosvg.so.0
``

@PedroHLC PedroHLC requested review from JohnRTitor and NickCao May 31, 2025 02:07
@PedroHLC PedroHLC added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 31, 2025
@Aleksanaa Aleksanaa merged commit 00826e9 into NixOS:master Jun 1, 2025
17 of 18 checks passed

patches = [
# https://github.com/sammycage/plutosvg/pull/29
./0001-Emit-correct-pkg-config-file-if-paths-are-absolute.patch
Copy link
Member

@PedroHLC PedroHLC Jun 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for not seeing this before, trying to use it I get:

>   Imported target "plutosvg::plutosvg" includes non-existent path
>
>     "/nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7/include/plutosvg"
>
>   in its INTERFACE_INCLUDE_DIRECTORIES.

in that output, there is only one file:

╰─λ find /nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7 -type f
/nix/store/jk7v5dwymmbj81i2qbmc2c1c2k5csfpn-plutosvg-0.0.7/lib/libplutosvg.so.0
``

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have also noticed this issue, it is already fixed upstream with sammycage/plutosvg#31. I was planning to add it as a patch with the PR updating pcsx2 but I can create a separate PR earlier if you need it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need @marcin-serwin, I've added a postInstall fix. Good work!

@marcin-serwin marcin-serwin deleted the push-yxtssnqvzxvl branch June 23, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants