This repository was archived by the owner on Oct 8, 2025. It is now read-only.
Exclude Core Chain and its testnet from zero fee configuration in gas fee logic#866
Closed
eric0x01 wants to merge 1 commit intoNomicFoundation:developmentfrom
Closed
Exclude Core Chain and its testnet from zero fee configuration in gas fee logic#866eric0x01 wants to merge 1 commit intoNomicFoundation:developmentfrom
eric0x01 wants to merge 1 commit intoNomicFoundation:developmentfrom
Conversation
Contributor
|
Thanks for the PR! I'm closing this in favor of a more flexible solution we've been meaning to add for a while that will let users set their own gas settings when needed, instead of relying on submitting PRs for each relevant chain. This should be available in the next Hardhat Ignition release this week! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on from #755, Updated the gas fee configuration logic to accommodate the Core Chain (chainId 1116) and testnet (chainId 1114) to exclude from zero fee configuration.