Add configurable maxFeePerGas and default to it if set#6857
Merged
Conversation
🦋 Changeset detectedLatest commit: 698dc70 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
Note that there is one integration test failing, however, I confirmed that this test is also failing for me locally on an unmodified |
fvictorio
reviewed
Jun 16, 2025
packages/hardhat-ignition-core/src/internal/execution/jsonrpc-client.ts
Outdated
Show resolved
Hide resolved
packages/hardhat-ignition-core/test-integrations/test-execution-result-fixtures.ts
Outdated
Show resolved
Hide resolved
zoeyTM
force-pushed
the
ignition/gas-config
branch
from
f14e3ed to
9e1c0a9
Compare
fvictorio
reviewed
Jun 17, 2025
...ges/hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts
Outdated
Show resolved
Hide resolved
zoeyTM
force-pushed
the
ignition/gas-config
branch
from
9e1c0a9 to
698dc70
Compare
fvictorio
approved these changes
Jun 18, 2025
Member
|
@zoeyTM can you open a PR for the docs, to add the new config option? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have this field configurable for
maxPriorityFeePerGasbut notmaxFeePerGas. By adding this and defaulting to it if its set by the user, we can eliminate the need for extending the hardcoded zero gas fee chains list such as in this PR.