Skip to content

fix NPM publishing#19

Merged
OmarTawfik merged 3 commits intonomicfrom
add-npmrc
Jun 30, 2025
Merged

fix NPM publishing#19
OmarTawfik merged 3 commits intonomicfrom
add-npmrc

Conversation

@OmarTawfik
Copy link

  • update package.json URLs
  • add publishConfig to package.json
  • add .npmrc file

@OmarTawfik OmarTawfik requested review from a team as code owners June 23, 2025 22:32
@OmarTawfik OmarTawfik enabled auto-merge June 23, 2025 23:02
"url": "https://github.com/bytecodealliance/jco/issues"
"url": "https://github.com/nomicfoundation/jco/issues"
},
"homepage": "https://github.com/nomicfoundation/jco#readme",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to expose our fork as the landing site of the package, it would be good to add information to the readme exposing that this is a fork from bytecodealliance, and what are the reasons for it. This is to help lost souls that got this package to know where to place issues.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid any unnecessary edits/changes to upstream files if possible.
I added a note about this in the homepage. WDYT?

Copy link

@ggiraldez ggiraldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Re: this comment adding one or two lines at the top of the README.md file wouldn't hurt. Maybe pointing to a new file (FORK.md?) where we can describe the purpose of the fork, what changes it introduces, and why we don't want to merge them upstream?

@OmarTawfik OmarTawfik added this pull request to the merge queue Jun 30, 2025
Merged via the queue into nomic with commit 5d94799 Jun 30, 2025
1 check passed
@OmarTawfik OmarTawfik deleted the add-npmrc branch July 3, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants