Skip to content

fix NPM publishing #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OmarTawfik merged 3 commits into from
Jun 30, 2025
Merged

fix NPM publishing #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
136cc36
add `.npmrc` file
OmarTawfik Jun 23, 2025
77492d5
add `publishConfig` to `package.json`
OmarTawfik Jun 23, 2025
ce0f8fd
update `package.json` URLs
OmarTawfik Jun 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
//registry.npmjs.org/:_authToken=${NPM_TOKEN}
10 changes: 7 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/bytecodealliance/jco.git"
"url": "git+https://github.com/nomicfoundation/jco.git"
},
"keywords": [
"Wasm",
Expand All @@ -53,9 +53,13 @@
],
"license": "(Apache-2.0 WITH LLVM-exception)",
"bugs": {
"url": "https://github.com/bytecodealliance/jco/issues"
"url": "https://github.com/nomicfoundation/jco/issues"
},
"homepage": "https://github.com/nomicfoundation/jco#readme",
Copy link

@beta-ziliani beta-ziliani Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're going to expose our fork as the landing site of the package, it would be good to add information to the readme exposing that this is a fork from bytecodealliance, and what are the reasons for it. This is to help lost souls that got this package to know where to place issues.

Copy link
Author

@OmarTawfik OmarTawfik Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to avoid any unnecessary edits/changes to upstream files if possible.
I added a note about this in the homepage. WDYT?

"publishConfig": {
"registry": "https://registry.npmjs.org/",
"access": "public"
},
"homepage": "https://github.com/bytecodealliance/jco#readme",
"scripts": {
"build": "cargo xtask build debug",
"build:release": "cargo xtask build release",
Expand Down