Skip to content

GANReviewTool: TemplateFinder #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NovemLinguae merged 23 commits into from
Dec 16, 2025
Merged

GANReviewTool: TemplateFinder #269

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d8890ea
GANReviewTool: TemplateFinder
bhsd-harry Oct 25, 2025
d51b3c6
GANReviewTool: remove unused code
bhsd-harry Oct 25, 2025
570931d
Merge branch 'master' into template
NovemLinguae Dec 2, 2025
e1bb931
move constructor to the top of the class
NovemLinguae Dec 2, 2025
60741a4
remove old comment
NovemLinguae Dec 2, 2025
892f551
add some tests
NovemLinguae Dec 2, 2025
22fe5c1
fix
NovemLinguae Dec 2, 2025
c63e888
fix
NovemLinguae Dec 2, 2025
07f1067
fix
NovemLinguae Dec 2, 2025
7fe735c
fix
NovemLinguae Dec 2, 2025
adf63ef
fix linter errors
NovemLinguae Dec 2, 2025
9a668eb
switch back to ??
NovemLinguae Dec 2, 2025
f47a8b6
add some tests demonstrating the power of the new library
NovemLinguae Dec 2, 2025
62a21fa
Rename 'root' to 'wikiPage' in TemplateFinder
bhsd-harry Dec 2, 2025
1520a24
Add comment about Wikipedia extension tags
bhsd-harry Dec 2, 2025
269c4ab
Merge branch 'master' into template
NovemLinguae Dec 3, 2025
df6bd79
fix tests
NovemLinguae Dec 3, 2025
c1fce96
these look like dev dependencies
NovemLinguae Dec 3, 2025
b33c512
Merge branch 'master' into template
NovemLinguae Dec 3, 2025
3eeee55
remove comma
NovemLinguae Dec 3, 2025
1c867b5
remove comment
NovemLinguae Dec 3, 2025
7109d54
Use esbuild to bundle JS files
bhsd-harry Dec 3, 2025
7d03cf2
Update publish.php
bhsd-harry Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions GANReviewTool/modules/TemplateFinder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,13 @@ export class TemplateFinder {
return String( this.root );
}

/** @returns {import('wikiparser-template').TranscludeToken} */
firstTemplate( templateNameRegExOrArrayCaseInsensitive ) {
let filter;
if ( !templateNameRegExOrArrayCaseInsensitive ) {
filter = () => true;
} else if ( Array.isArray( templateNameRegExOrArrayCaseInsensitive ) ) {
const templateNameArray = templateNameRegExOrArrayCaseInsensitive
.map( name => name.toLowerCase().replace( /\s/g, '_' ) );
.map( ( name ) => name.toLowerCase().replace( /\s/g, '_' ) );
filter = ( { name } ) => templateNameArray.includes( TemplateFinder.removePrefix( name ).toLowerCase() );
} else {
const regEx = new RegExp( `^Template:${ templateNameRegExOrArrayCaseInsensitive }$`, 'i' );
Expand All @@ -42,7 +41,7 @@ export class TemplateFinder {
if ( !template ) {
return null;
}
return template.getValue( parameter ) ?? null;
return template.getValue( parameter ) || null;
}

firstTemplateDeleteParameter( templateNameRegExOrArrayCaseInsensitive, parameter ) {
Expand Down