GANReviewTool: TemplateFinder

[bhsd-harry]

Hi! Will it be better if I split my PR (#260) into multiple smaller ones like this?

[NovemLinguae]

So sorry for the delay in reviewing this. Very nice job. Yes, smaller PRs are easier for me to review, thank you for that.

[NovemLinguae]

I was about to merge this, then I realized I had no way to deploy it since this patch introduces this script's first non-dev dependency, wikiparser-template. The deploy script publish.php will need to be modified to download wikiparser-template's combined code, then add it in with the rest of the GANReviewTool code.

[NovemLinguae]

If it's easier to rewrite the deploy script from scratch in Node (so that you can use libraries like concat), rather than update publish.php, that's fine. We can tie the node script to npm run deploy, which is the standard deploy command for several wikimedia gadget repos.

I'd be OK with wikiparser-template being transpiled/minified. I'd like to keep the other files un-minified though for easier debugging.

[bhsd-harry]

If it's easier to rewrite the deploy script from scratch in Node (so that you can use libraries like concat), rather than update publish.php, that's fine. We can tie the node script to npm run deploy, which is the standard deploy command for several wikimedia gadget repos.

I don't understand how PHP works, so I just add a npm run build script to bundle all JS files into dist/GANReviewTool.js. You may treat it as $MAIN_FILE_PATH and run the PHP script.

[bhsd-harry]

I have updated publish.php to make the deployment more straightforward. After changing $MAIN_FILE_PATH to dist/GANReviewTool.js, you only need to run npm run build which bundles all JS files before executing publish.php.

[NovemLinguae]

Tested, works. Thanks for your patience throughout this process!

I may replace publish.php with something in Node in a future patch. Would be nice to write a npm run deploy command that did npm run build && [add <nowiki> tags to top and bottom] && [call mwn wikibot library to write the wikicode onwiki]

[NovemLinguae]

We should still keep #138, #209, and #214 open, correct? There's a little more conversion to be done in files such as MassGARWikicodeGenerator.js?

[bhsd-harry]

We should still keep #138, #209, and #214 open, correct? There's a little more conversion to be done in files such as MassGARWikicodeGenerator.js?

Yes, you are right. I will prepare follow-up PRs later.