Skip to content

Conversation

@juicetin
Copy link
Contributor

@juicetin juicetin commented Apr 16, 2025

Description

  • add case insensitivity for priority threshold, update to the 3 labels available in our agents
  • I've marked this as major because the label change is technically a breaking change - can adjust based on comments
    • the old labels aren't explicitly used anywhere in code
    • customers may already have the old labels in their config files though - I may need to update this PR to account for that
    • though - https://docs.nullify.ai/getting-started/configuration-general priorityThreshold is not yet documented so we can still change it at will and have it technically not be a breaking change 😅

Test Plan

Please include steps to test the change. Include screenshots if applicable.

Checklist

  • I have performed a self-review of my own code
  • I have checked for redundant or commented out code
  • I have made corresponding changes to the documentation
  • I have added any appropriate tests

@juicetin juicetin added the major major breaking changes label Apr 16, 2025
@juicetin juicetin requested review from HarvWorks and andsnw April 16, 2025 07:34
@juicetin juicetin self-assigned this Apr 16, 2025
@juicetin juicetin requested a review from vik-nullify April 16, 2025 07:34
@juicetin juicetin added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 7e0a400 Apr 16, 2025
7 checks passed
@juicetin juicetin deleted the feat/ENT-923 branch April 16, 2025 07:39
@tim-thacker-nullify tim-thacker-nullify removed the major major breaking changes label Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants