-
Notifications
You must be signed in to change notification settings - Fork 29
1.x: the hopefully last two typos #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mikekistler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. 👍
|
Two things here:
|
9c033d7 to
ad1586c
Compare
lornajane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First contributions to the 1.0.1 spec and they look good :)
|
(be careful, I rebased it on the v1.0-dev branch to sort out some conflicts) |
|
@lornajane @mikekistler Can this PR be merged? |
|
It needs a second review but otherwise I think we're all set |
mikekistler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
Some minor copyedits that we spotted when reviewing around the time of the 1.0 release.