[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label#927
[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label#927
Conversation
2557b28 to
083e9cb
Compare
Jaimermaccione
left a comment
There was a problem hiding this comment.
LGTM! Functional review in Runboat
| <span t-field="dest_picking.partner_id.name" /> | ||
| <t t-if="dest_picking.partner_id.contact_address"> | ||
| <br /><span | ||
| t-raw="dest_picking.partner_id.contact_address" | ||
| /> | ||
| </t> | ||
| <t t-if="dest_picking.partner_id.phone"> | ||
| <br /><t t-esc="dest_picking.partner_id.phone" /> | ||
| </t> | ||
| <t t-if="dest_picking.partner_id.mobile"> | ||
| <br /><t t-esc="dest_picking.partner_id.mobile" /> | ||
| </t> |
There was a problem hiding this comment.
| <span t-field="dest_picking.partner_id.name" /> | |
| <t t-if="dest_picking.partner_id.contact_address"> | |
| <br /><span | |
| t-raw="dest_picking.partner_id.contact_address" | |
| /> | |
| </t> | |
| <t t-if="dest_picking.partner_id.phone"> | |
| <br /><t t-esc="dest_picking.partner_id.phone" /> | |
| </t> | |
| <t t-if="dest_picking.partner_id.mobile"> | |
| <br /><t t-esc="dest_picking.partner_id.mobile" /> | |
| </t> | |
| <div | |
| class="col-5 border border-dark rounded text-center" | |
| style="padding: 10px 0; min-height: 140px" | |
| name="client" | |
| > | |
| <span t-field="dest_picking.partner_id" t-options="{'widget': 'contact', 'fields': ['name', 'address', 'phone', 'mobile'], 'no_marker': true}"/> | |
| </div> |
There was a problem hiding this comment.
I'll do this
We take advantage of the widget to have less lines.
Also, i think reducing the padding of the div is important because, if the address is too big, it can overflow and jump to a new report page
There was a problem hiding this comment.
@rlizana This is an example of the report with my suggestions
|
Hi @rlizana Sorry if I was too abrupt with my previous comment. Our organization finds it very useful to add this, but I think the code has certain improvements that I have mentioned to you. Could you review them and respond? If you are no longer available to work on this PR we can continue it with a FW PORT Thank you |
|
Solved in #939 The PR can be closed |
|
@pedrobaeza do you mind closing this PR? It's not going to be continued as it has been solved in another one. Sorry, I don't have "powers" in this repository |

Current label, no address and no phone

with these changes the label shows address and phone number
