Skip to content

[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label#927

Closed
rlizana wants to merge 1 commit intoOCA:16.0from
rlizana:imp_delivery_package_number_label
Closed

[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label#927
rlizana wants to merge 1 commit intoOCA:16.0from
rlizana:imp_delivery_package_number_label

Conversation

@rlizana
Copy link
Contributor

@rlizana rlizana commented Jan 2, 2025

Current label, no address and no phone
image

with these changes the label shows address and phone number
image

@rlizana rlizana force-pushed the imp_delivery_package_number_label branch from 2557b28 to 083e9cb Compare January 3, 2025 06:39
@pedrobaeza pedrobaeza added this to the 16.0 milestone Jan 3, 2025
Copy link

@Jaimermaccione Jaimermaccione left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Functional review in Runboat

Comment on lines +41 to +52
<span t-field="dest_picking.partner_id.name" />
<t t-if="dest_picking.partner_id.contact_address">
<br /><span
t-raw="dest_picking.partner_id.contact_address"
/>
</t>
<t t-if="dest_picking.partner_id.phone">
<br /><t t-esc="dest_picking.partner_id.phone" />
</t>
<t t-if="dest_picking.partner_id.mobile">
<br /><t t-esc="dest_picking.partner_id.mobile" />
</t>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span t-field="dest_picking.partner_id.name" />
<t t-if="dest_picking.partner_id.contact_address">
<br /><span
t-raw="dest_picking.partner_id.contact_address"
/>
</t>
<t t-if="dest_picking.partner_id.phone">
<br /><t t-esc="dest_picking.partner_id.phone" />
</t>
<t t-if="dest_picking.partner_id.mobile">
<br /><t t-esc="dest_picking.partner_id.mobile" />
</t>
<div
class="col-5 border border-dark rounded text-center"
style="padding: 10px 0; min-height: 140px"
name="client"
>
<span t-field="dest_picking.partner_id" t-options="{'widget': 'contact', 'fields': ['name', 'address', 'phone', 'mobile'], 'no_marker': true}"/>
</div>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this
We take advantage of the widget to have less lines.

Also, i think reducing the padding of the div is important because, if the address is too big, it can overflow and jump to a new report page

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlizana This is an example of the report with my suggestions

Captura desde 2025-02-10 18-09-11

@Tisho99
Copy link
Contributor

Tisho99 commented Feb 12, 2025

Hi @rlizana

Sorry if I was too abrupt with my previous comment.

Our organization finds it very useful to add this, but I think the code has certain improvements that I have mentioned to you.

Could you review them and respond?

If you are no longer available to work on this PR we can continue it with a FW PORT

Thank you

Copy link
Contributor

@sergio-teruel sergio-teruel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlizana Can you add @Tisho99 suggestions??

Thanks!!!

@Tisho99
Copy link
Contributor

Tisho99 commented Feb 17, 2025

Solved in #939

The PR can be closed

@HaraldPanten
Copy link

@pedrobaeza do you mind closing this PR? It's not going to be continued as it has been solved in another one.

Sorry, I don't have "powers" in this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants