Skip to content

[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlizana wants to merge 1 commit into from
Closed

[16.0][IMP] delivery_package_number: add delivery address and phone to the shipping label #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion delivery_package_number/reports/report_package_number.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,18 @@
style="padding: 60px 0;"
name="client"
>
<span t-field="dest_picking.partner_id" />
<span t-field="dest_picking.partner_id.name" />
<t t-if="dest_picking.partner_id.contact_address">
<br /><span
t-raw="dest_picking.partner_id.contact_address"
/>
</t>
<t t-if="dest_picking.partner_id.phone">
<br /><t t-esc="dest_picking.partner_id.phone" />
</t>
<t t-if="dest_picking.partner_id.mobile">
<br /><t t-esc="dest_picking.partner_id.mobile" />
</t>
Comment on lines +41 to +52
Copy link
Contributor

@Tisho99 Tisho99 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<span t-field="dest_picking.partner_id.name" />
<t t-if="dest_picking.partner_id.contact_address">
<br /><span
t-raw="dest_picking.partner_id.contact_address"
/>
</t>
<t t-if="dest_picking.partner_id.phone">
<br /><t t-esc="dest_picking.partner_id.phone" />
</t>
<t t-if="dest_picking.partner_id.mobile">
<br /><t t-esc="dest_picking.partner_id.mobile" />
</t>
<div
class="col-5 border border-dark rounded text-center"
style="padding: 10px 0; min-height: 140px"
name="client"
>
<span t-field="dest_picking.partner_id" t-options="{'widget': 'contact', 'fields': ['name', 'address', 'phone', 'mobile'], 'no_marker': true}"/>
</div>

Copy link
Contributor

@Tisho99 Tisho99 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this
We take advantage of the widget to have less lines.

Also, i think reducing the padding of the div is important because, if the address is too big, it can overflow and jump to a new report page

Copy link
Contributor

@Tisho99 Tisho99 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlizana This is an example of the report with my suggestions

Captura desde 2025-02-10 18-09-11

</div>
<div class="col-2" />
<div
Expand Down
Loading