Skip to content

[IMP] bump setuptools-odoo version in all branches#333

Merged
sbidoul merged 1 commit intoOCA:masterfrom
hbrunn:master-bump-setuptools-odoo
Feb 17, 2026
Merged

[IMP] bump setuptools-odoo version in all branches#333
sbidoul merged 1 commit intoOCA:masterfrom
hbrunn:master-bump-setuptools-odoo

Conversation

@hbrunn
Copy link
Member

@hbrunn hbrunn commented Feb 17, 2026

after the pkg_resourcalypse, I think we should do that across the board.

Or would it be more prudent to create a constraint file to set PIP_BUILD_CONSTRAINT to?

Test v16 repo: OCA/event#495

@hbrunn hbrunn requested a review from sbidoul February 17, 2026 07:40
@hbrunn
Copy link
Member Author

hbrunn commented Feb 17, 2026

@StefanRijnhart
Copy link
Member

@sbidoul Thanks for the merge! Will this fix https://github.com/OCA/oca-ci/actions/runs/22051093544 as well or do we need to fix that separately with a version hint for setuptools?

@hbrunn
Copy link
Member Author

hbrunn commented Feb 17, 2026

it won't, for this we really need the constrains file I think

@sbidoul
Copy link
Member

sbidoul commented Feb 17, 2026

I'll look at oca-ci.

For pre-commit yeah, the problem with it is that it does not pin transitive dependencies.

@sbidoul
Copy link
Member

sbidoul commented Feb 17, 2026

Tracking oca-ci build here: OCA/oca-ci#118

@hbrunn
Copy link
Member Author

hbrunn commented Feb 17, 2026

I've hacked this for some openupgrade workflows: https://github.com/OCA/OpenUpgrade/blob/18.0/.github/workflows/documentation-commit.yml#L55-L56

@sbidoul
Copy link
Member

sbidoul commented Feb 17, 2026

Yes, that works too, but if we can avoid global build constraints that will be more robust. Because one day some dependency will require setuptools>=82 to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants