-
-
Notifications
You must be signed in to change notification settings - Fork 534
[19.0] [MIG] queue_job_batch: migrate + tests #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
hoangtrann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me at first glance, I'll run the test locally and circle back
hoangtrann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the test-requirements.txt and check if tests are now passing too
04b95b2 to
830a076
Compare
Scope: queue_job_batch, test_queue_job_batch
830a076 to
63933a5
Compare
|
Hi @hoangtrann, thanks for the review.
CI is green now. @sbidoul |
Scope
Depends on
Summary
Temporary references
This will be removed once the base PR merges.
Pre-commit
Tests
test_queue_job_batch when queue_job/test_queue_job are not present.