Skip to content

Conversation

@tishmen
Copy link

@tishmen tishmen commented Oct 1, 2025

Scope

  • queue_job_batch, test_queue_job_batch

Depends on

Summary

  • Migrate to Odoo 19; tests included. No functional changes beyond compatibility.

Temporary references

  • test-requirements.txt adds temporary dependencies to the base PR for CI/runboat.
    This will be removed once the base PR merges.

Pre-commit

  • Ran locally; auto-fixes committed.

Tests

  • CI will run the suite using the referenced base PR. Local isolated runs may skip
    test_queue_job_batch when queue_job/test_queue_job are not present.

@tishmen tishmen marked this pull request as draft October 1, 2025 19:37
@tishmen tishmen marked this pull request as ready for review October 1, 2025 19:41
@tishmen tishmen changed the title [19.0] queue_job_batch: migrate + tests [19.0] [MIG] queue_job_batch: migrate + tests Oct 1, 2025
Copy link
Contributor

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me at first glance, I'll run the test locally and circle back

Copy link
Contributor

@hoangtrann hoangtrann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the test-requirements.txt and check if tests are now passing too

@tishmen tishmen force-pushed the pr3/queue_job_batch branch from 04b95b2 to 830a076 Compare January 9, 2026 17:26
Scope: queue_job_batch, test_queue_job_batch
@tishmen tishmen force-pushed the pr3/queue_job_batch branch from 830a076 to 63933a5 Compare January 9, 2026 17:32
@tishmen tishmen requested a review from hoangtrann January 9, 2026 17:35
@tishmen
Copy link
Author

tishmen commented Jan 9, 2026

Hi @hoangtrann, thanks for the review.

  • Removed the migration-related inline comments you pointed out.
  • Dropped the temporary test-requirements.txt (git URL refs) and restored requirements.txt.
  • Rebased on latest 19.0, then squashed everything into a single [19.0][MIG] queue_job_batch: migrate commit.

CI is green now. @sbidoul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants