Add ingress class name k8s v1.18+#10
Open
nicolas-topsemaj wants to merge 3 commits intoOCSInventory-NG:mainfrom
Open
Add ingress class name k8s v1.18+#10nicolas-topsemaj wants to merge 3 commits intoOCSInventory-NG:mainfrom
nicolas-topsemaj wants to merge 3 commits intoOCSInventory-NG:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need for k8s clusters v1.18+ the ingressClassName in the ingress.
This PR adds the ability to add either the ingressClassName or the ingress class annotation, with a version check to avoid errors.
Tested on k8s v1.25.6
(tests on version v1.18 or less are welcome)