Skip to content

Refactor client state persistence and add more tests#3303

Merged
marcschier merged 21 commits intomasterfrom
statemodels
Nov 1, 2025
Merged

Refactor client state persistence and add more tests#3303
marcschier merged 21 commits intomasterfrom
statemodels

Conversation

@marcschier
Copy link
Collaborator

@marcschier marcschier commented Oct 30, 2025

Proposed changes

Describe the changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Related Issues

  • Fixes #

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply. You can also fill these out after creating the PR.

  • Bugfix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds functionality)
  • Test enhancement (non-breaking change to increase test coverage)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected, requires version increase of Nuget packages)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc.
  • I have signed the CLA.
  • I ran tests locally with my changes, all passed.
  • I fixed all failing tests in the CI pipelines.
  • I fixed all introduced issues with CodeQL and LGTM.
  • I have added tests that prove my fix is effective or that my feature works and increased code coverage.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

❌ Patch coverage is 73.78788% with 519 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.36%. Comparing base (8f5a042) to head (73cdc54).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...braries/Opc.Ua.Client/Session/SessionExtensions.cs 30.98% 95 Missing and 3 partials ⚠️
...s/Opc.Ua.Client/Session/SessionClientExtensions.cs 74.18% 85 Missing and 10 partials ⚠️
...raries/Opc.Ua.Client/NodeCache/NodeCacheContext.cs 85.15% 58 Missing and 25 partials ⚠️
Libraries/Opc.Ua.Client/Browser.cs 74.55% 64 Missing and 7 partials ⚠️
...raries/Opc.Ua.Client/Subscription/MonitoredItem.cs 53.27% 38 Missing and 12 partials ⚠️
...ies/Opc.Ua.Client/Session/DefaultSessionFactory.cs 76.06% 39 Missing and 6 partials ⚠️
...braries/Opc.Ua.Client/Subscription/Subscription.cs 81.92% 21 Missing and 9 partials ⚠️
Libraries/Opc.Ua.Client/NodeCache/NodeCache.cs 78.26% 9 Missing and 1 partial ⚠️
...ent.ComplexTypes/TypeResolver/NodeCacheResolver.cs 30.76% 9 Missing ⚠️
...s/Opc.Ua.Client/Subscription/MonitoredItemState.cs 46.15% 7 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
+ Coverage   59.21%   59.36%   +0.15%     
==========================================
  Files         320      323       +3     
  Lines       76270    75777     -493     
  Branches    13300    13329      +29     
==========================================
- Hits        45166    44988     -178     
+ Misses      27034    26723     -311     
+ Partials     4070     4066       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcschier marcschier requested a review from Copilot October 30, 2025 17:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@marcschier marcschier marked this pull request as ready for review October 31, 2025 05:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@marcschier marcschier requested a review from Copilot October 31, 2025 12:10
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

marcschier and others added 8 commits October 31, 2025 23:10
Increased the delay between session creation attempts from 1000ms to 10000ms to handle transient errors more effectively.
Updated channel attachment logic to assign transport channel directly.
@marcschier marcschier merged commit 1c17840 into master Nov 1, 2025
143 of 144 checks passed
@marcschier marcschier deleted the statemodels branch November 1, 2025 16:18
Daniel-Alblas-VFI added a commit to Daniel-Alblas-VFI/UA-.NETStandard that referenced this pull request Jan 14, 2026
With the changes in OPCFoundation#3303 it seems that values are now always overwritten by values set in the server in FetchOperationLimitsAsync, rather than only in the case described in the remarks of OperationLimits.
@Daniel-Alblas-VFI Daniel-Alblas-VFI mentioned this pull request Jan 14, 2026
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants