Bug: update MatrixHandler::addConst return type to int
#402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkoukpaizan
changed the base branch from
develop
to
maanas_arora/add_const_return_type
nkoukpaizan
approved these changes
Jan 5, 2026
Collaborator
nkoukpaizan
left a comment
nkoukpaizan
left a comment
There was a problem hiding this comment.
Looks good to me. Tests pass, except the push to the build cache. Changed the base of the merge to a branch within the ORNL/ReSolve space, so we can re-run CI on this branch before merging to develop.
Collaborator
|
Thanks for catching this and submitting a pull request @MaanasArora! |
pelesh
approved these changes
Jan 5, 2026
pelesh
merged commit 23da075
into
ORNL:maanas_arora/add_const_return_type
4 of 21 checks passed
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #395.
I'm a new contributor to this project - I'm interested in scientific computing and want to help with performance optimization and research. Thanks for reviewing!
Proposed changes
Updates
MatrixHandler::addConstto int return type to match the documentation. There are no error returns yet, and as stated in the issue any don't seem obvious yet, but still seems useful for consistency.Note: I've updated the changelog, was not sure, but happy to revert if this change is too minor.
Checklist
-Wall -Wpedantic -Wconversion -Wextra.