Revert "fix icons by setting x_sendfile_header"#5028
Merged
Conversation
This reverts commit 611be23.
Bubballoo3
approved these changes
Jan 28, 2026
Contributor
Bubballoo3
left a comment
Bubballoo3
left a comment
There was a problem hiding this comment.
LGTM! Tested with this and #5029 and was able to get the icons outside the allowlist without any log warnings
github-project-automation
bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5007
I think we need to revert this because of #5025. #5025 mentions it's outputting during tests, but this is also the case when the app is running and I know that folks are not going to like these messages being printed all the time in the logs.
I'm working on a solution to actually just read the file and serve it while setting all the headers manually.