Conversation
Bubballoo3
approved these changes
Jan 28, 2026
github-project-automation
bot
moved this from Awaiting Review
to Merged/Closed
in PR Review Pipeline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #5028 and the PR that it's reverting.
Instead of having nginx serve these files through
send_filethat generates extra log messages, instead we'll use rails' utility torenderany file without a layout.This means it's done purely in ruby which has a performance hit, but I believe enabling the
x-accel-mappingheader may have security issues. I'm not 100% sure how a specially crafted request may getsend_filecoupled with ax-accel-mappingheader to access files outside of the ALLOWLIST, but I figure this can turn a 1 in a million chance to 0, so that's the trade I'm willing to make.