Skip to content

Conversation

@pjonsson
Copy link
Contributor

Make the script that generates proj_symbol_rename.h use the libproj.so built by the regular build system instead of compiling its own library.

Re-generate proj_symbol_rename.h with the updated script, and keep the long lines to make it easier to spot differences in the future. This adds 2 new symbols to the header.

  • Added clear title that can be used to generate release notes

Use the libproj.so built by the build system
to extract the list of externally visible
functions. This ensures the library is built
in the same way as the release.
@rouault
Copy link
Member

rouault commented Jan 15, 2026

Maybe add an exception to .pre-commit-config.yaml (at root of the repo) so that it doesn't try to reformat proj_symbol_rename.h

Do not reformat the header file
generated by a script.

This works with clang-format 18
which is shipped with Ubuntu 24.04.
@pjonsson
Copy link
Contributor Author

Maybe add an exception to .pre-commit-config.yaml (at root of the repo)

Ok, added a clang-format-ignore as well while I was at it. I'm afraid I clogged up the CI with my 2 consecutive pushes though, sorry about that!

@rouault
Copy link
Member

rouault commented Jan 15, 2026

I'm afraid I clogged up the CI with my 2 consecutive pushes though, sorry about that!

No, that should be fine. We have the following statement in the CI .yml that cancels previous tasks related to a PR:

concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
  cancel-in-progress: true

@pjonsson
Copy link
Contributor Author

I'm not sure how the PROJ release schedule intertwines with the GDAL release schedule, will this fix be a part of GDAL 3.13.0?

@rouault
Copy link
Member

rouault commented Jan 16, 2026

will this fix be a part of GDAL 3.13.0?

more exactly PROJ 9.8 is planned to be released beginning of march, so before GDAL 3.13

@rouault rouault added this to the 9.8.0 milestone Jan 16, 2026
@rouault rouault merged commit 76889e1 into OSGeo:master Jan 16, 2026
30 checks passed
@pjonsson pjonsson deleted the update-rename-list branch January 16, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants