adding tags to be returned as part of the tag_set data call#570
adding tags to be returned as part of the tag_set data call#570garkenxian wants to merge 2 commits intoOctopusDeployLabs:mainfrom
Conversation
…to them as part of the data call
updating tag_sets to return list of canonical tags that are assigned …
| } | ||
| } | ||
|
|
||
| func getTagSchemaForTagSet() map[string]*schema.Schema { |
There was a problem hiding this comment.
the getTagSchema() from schema_tag.go has a few extra values that is not needed here.
zentron
left a comment
zentron
left a comment
There was a problem hiding this comment.
Thanks for this PR @eternalapprentice2000 .
Could you please update the TagSet Integration Test to validate that these values are returned.
In addition you may want to exclude all the non essential .devcontainer/ files from this PR.
I noticed one of the files you included contained an API Key, hopefully thats not copied from a production Octopus instance you have otherwise you may want to rotate it.
| @@ -0,0 +1,14 @@ | |||
| { | |||
| "name": "golang build env", | |||
There was a problem hiding this comment.
Looks like these devcontainer files were added to the commit, you may want to update the .gitignore
| ACCEPT_EULA: "Y" | ||
| ADMIN_USERNAME: admin | ||
| ADMIN_PASSWORD: "P@ssw0rd!" | ||
| ADMIN_API_KEY: API-L2GV2ELTCZDRANT1OQO045GPZHXFGWR |
There was a problem hiding this comment.
If you copied this API key from a "real" octopus server you may want to revoke the key given its now appeared publicly
3 participants
#567
please be kind, this is my first foray into Go and working with Terraform providers. Thanks