Skip to content

Conversation

@bosd
Copy link
Member

@bosd bosd commented Sep 25, 2025

Remove the last remaining connection.is_connected() call that was causing AttributeError

  • This was a leftover from earlier fixes that wasn't completely removed
  • Fixes the AttributeError: 'Connection' object has no attribute 'is_connected'

…aining connection.is_connected() call that was causing AttributeError\n- This was a leftover from earlier fixes that wasn't completely removed\n- Fixes the AttributeError: 'Connection' object has no attribute 'is_connected'
@gemini-code-assist
Copy link

Summary of Changes

Hello @bosd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR addresses a runtime error that occurred due to an outdated method call within the Odoo data flow library. By removing the is_connected() check, the system avoids an AttributeError and ensures the connection handling logic proceeds as intended, improving the stability of relational imports.

Highlights

  • AttributeError Resolution: The pull request resolves an "AttributeError: 'Connection' object has no attribute 'is_connected'" by removing a problematic call to connection.is_connected(). This call was a leftover from previous refactorings and was no longer valid.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This change correctly removes a call to connection.is_connected() that was causing an AttributeError. My review includes a comment pointing out that another similar call exists elsewhere in the file and should also be removed to complete the fix.

@bosd
Copy link
Member Author

bosd commented Sep 25, 2025

Code Review

This change correctly removes a call to connection.is_connected() that was causing an AttributeError. My review includes a comment pointing out that another similar call exists elsewhere in the file and should also be removed to complete the fix.

So where is the other occurence?

@bosd bosd merged commit 0a7713d into master Sep 25, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants