Skip to content

Fix remaining connection.is_connected() call #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosd merged 1 commit into from
Sep 25, 2025
Merged

Fix remaining connection.is_connected() call #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/odoo_data_flow/lib/relational_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,6 @@ def _resolve_related_ids(
connection = conf_lib.get_connection_from_dict(config)
else:
connection = conf_lib.get_connection_from_config(config_file=config)
if not connection.is_connected():
log.error("Cannot perform XML-ID lookup: Odoo connection failed.")
return None

id_list = external_ids.drop_nulls().unique().to_list()
log.info(f"Resolving {len(id_list)} unique external IDs for '{related_model}'...")
Expand Down
Loading