feat: ETH transfers custom native token chains part 2 #2274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if (isCctpTransfer) { | ||
| return transferCctp() | ||
| } | ||
| if (isDepositMode && nativeCurrency.isCustom && isSelectedTokenEther) { |
Contributor
There was a problem hiding this comment.
We can abstract this into it's own function which can be reused to identify the transfer case that is being implemented in these set of PRs.
isEthTransferToCustomNativeCurrencyChain(), and it's corresponding hook.
This flag can also be used in other places to show different UI case by case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only wrapping and deposit logic. UI not adjusted like summary panel, dialog content, etc.