-
Notifications
You must be signed in to change notification settings - Fork 218
feat: ETH transfers custom native token chains part 2 #2274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
brtkx
wants to merge
2
commits into
eth-custom-orbit-1
Choose a base branch
from
eth-custom-orbit-2
base: eth-custom-orbit-1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
packages/arb-token-bridge-ui/src/components/TransferPanel/wrapEther.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| import { getArbitrumNetwork } from '@arbitrum/sdk' | ||
| import { ethers, Signer } from 'ethers' | ||
|
|
||
| const WETH_ABI = [ | ||
| { | ||
| constant: false, | ||
| inputs: [], | ||
| name: 'deposit', | ||
| outputs: [], | ||
| payable: true, | ||
| stateMutability: 'payable', | ||
| type: 'function' | ||
| } | ||
| ] | ||
|
|
||
| export async function wrapEther({ | ||
| signer, | ||
| sourceChainId, | ||
| amount | ||
| }: { | ||
| signer: Signer | ||
| sourceChainId: number | ||
| amount: string | number | ||
| }) { | ||
| const wethAddress = getArbitrumNetwork(sourceChainId).tokenBridge?.childWeth | ||
|
|
||
| if (!wethAddress) { | ||
| throw new Error('Error wrapping ETH: No WETH address found.') | ||
| } | ||
|
|
||
| try { | ||
| const wethContract = new ethers.Contract(wethAddress, WETH_ABI, signer) | ||
| const amountInWei = ethers.utils.parseEther(amount.toString()) | ||
|
|
||
| const tx = await wethContract.deposit({ | ||
| value: amountInWei | ||
| }) | ||
|
|
||
| return tx.wait() | ||
| } catch (error) { | ||
| console.error('Error wrapping ETH:', error) | ||
| throw error | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can abstract this into it's own function which can be reused to identify the transfer case that is being implemented in these set of PRs.
isEthTransferToCustomNativeCurrencyChain(), and it's corresponding hook.This flag can also be used in other places to show different UI case by case.