Skip to content

Fix Beacon API host validation in validator service #16046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maradini77 wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix Beacon API host validation in validator service #16046

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b9cd89
Update service.go
maradini77 Nov 24, 2025
4f90822
Create maradini77_patch-2.md
maradini77 Nov 25, 2025
95d225c
Update maradini77_patch-2.md
maradini77 Nov 25, 2025
69e2c0e
Update service.go
maradini77 Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion validator/client/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,14 @@ func (v *ValidatorService) Start() {
}

u := strings.ReplaceAll(v.conn.GetBeaconApiUrl(), " ", "")
hosts := strings.Split(u, ",")
rawHosts := strings.Split(u, ",")
Copy link
Contributor

@james-prysm james-prysm Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a unit test and changelog

hosts := make([]string, 0, len(rawHosts))
for _, host := range rawHosts {
if host == "" {
continue
}
hosts = append(hosts, host)
}
if len(hosts) == 0 {
log.WithError(err).Error("No API hosts provided")
return
Expand Down