-
Notifications
You must be signed in to change notification settings - Fork 108
Add @supportSync parsing logic for Custom Function Sync #947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azurepipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
It would be better to add some tests in https://github.com/OfficeDev/Office-Addin-Scripts/tree/9fb9b4a3be426f4d2a079c062cc5c483aa19c5c7/packages/custom-functions-metadata/test. Maybe we can do that in next PR. |
Will do in future. |
@millerds Can you help review and approve the latest iteration? |
New policy changes prevent me from checking in over the SDL failure, which seems to happen with doing a cross fork PR (haven't figured out what to do about that yet). You may have to create a new PR directly in the repo (use the user/* branch name pattern used in OMR) instead of a fork. |
Can you add me as contributor? I need access to create branch in this repo. |
Thank you for your pull request!
Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.
Change Description:
Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters)
No
Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins)
No
If you answered yes to any of these please do the following:
> Include 'Rick-Kirkham' in the review
> Make sure the README file is correct
Validation/testing performed: