Interrupt management optimize and minor fixes

[424778940z]

Summary by CodeRabbit

• Refactor
  • Streamlined the startup process to better manage external communications during initialization.
• Bug Fixes
  • Resolved issues with unexpected interrupt behavior for improved startup stability.
• Chores
  • Updated firmware version information to accurately reflect the major release.
• New Features
  • Enhanced the initialization of communication interfaces to ensure a robust and reliable system start.
  • Improved interrupt management during bootloader and firmware initialization for better control.

[coderabbitai]

Walkthrough

The pull request updates several initialization routines. The bootloader and firmware codes are revised to disable and clear interrupts early, ensuring reliable system startup. The firmware now removes an external vector offset assignment and streamlines vector table loading. A version header fix corrects a macro definition for the major version. Additionally, the USART initialization now aborts ongoing transfers and clears pending DMA and UART interrupts before configuration.

Changes

File(s)	Change Summary
core/embed/bootloader/main.c and .../startup.s	Enhanced interrupt management during bootloader initialization; added calls to disable and clear interrupts.
core/embed/firmware/main.c and .../startup.S	Removed external vector offset assignment; updated interrupt handling and vector table loading with system clock and DWT initialization.
core/embed/firmware/version.h	Updated macro FIX_VERSION_MAJOR to use VERSION_MAJOR instead of VERSION_MINOR.
core/embed/trezorhal/usart.c	Added HAL_UART_Abort and calls to clear pending DMA and UART interrupts to improve USART initialization.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro (Legacy)

📥 Commits

Reviewing files that changed from the base of the PR and between 4457d0d and 62895e4.

📒 Files selected for processing (6)

• core/embed/bootloader/main.c (2 hunks)
• core/embed/bootloader/startup.s (1 hunks)
• core/embed/firmware/main.c (2 hunks)
• core/embed/firmware/startup.S (1 hunks)
• core/embed/firmware/version.h (1 hunks)
• core/embed/trezorhal/usart.c (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (6)

• core/embed/bootloader/startup.s
• core/embed/trezorhal/usart.c
• core/embed/firmware/version.h
• core/embed/firmware/main.c
• core/embed/bootloader/main.c
• core/embed/firmware/startup.S

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Style check
• GitHub Check: Defs check
• GitHub Check: Gen check

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[424778940z]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.