Skip to content

Conversation

@nan-li
Copy link
Contributor

@nan-li nan-li commented Jan 9, 2026

Description

One Line Summary

Fix an error in typo, and fix failing build for release: https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/20834750173/job/59857183379

Details

Motivation

Fix an error in typo, and fix failing build for release: https://github.com/OneSignal/OneSignal-iOS-SDK/actions/runs/20834750173/job/59857183379

Scope

No live activities for mac catalyst

Testing

Manual testing

Dev app builds and runs
Confirmed click events tracked correctly

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li nan-li requested a review from a team January 9, 2026 01:39
@nan-li nan-li changed the title fix: blank out OSLiveActivityViewExtensions for mac catalyst fix: typo in endpoint and blank out OSLiveActivityViewExtensions for mac catalyst Jan 9, 2026
@nan-li nan-li merged commit 04a1f2c into main Jan 9, 2026
2 of 3 checks passed
@nan-li nan-li deleted the fix/no_live_activity_for_mac branch January 9, 2026 17:11
@github-actions github-actions bot mentioned this pull request Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants