Skip to content

fix: typo in endpoint and blank out OSLiveActivityViewExtensions for mac catalyst #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nan-li merged 2 commits into from
Jan 9, 2026
Merged

fix: typo in endpoint and blank out OSLiveActivityViewExtensions for mac catalyst #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8457e72
fix: blank out `OSLiveActivityViewExtensions` for mac catalyst
nan-li Jan 9, 2026
5fbccf1
fix typo in OSRequestLiveActivityClicked
nan-li Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions iOS_SDK/OneSignalSDK/OneSignalLiveActivities/Source/OSLiveActivityViewExtensions.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
THE SOFTWARE.
*/

// Effectively blanks out this file for Mac Catalyst
#if targetEnvironment(macCatalyst)
#else
import WidgetKit
import ActivityKit
import SwiftUI
Expand Down Expand Up @@ -143,3 +146,4 @@ enum LiveActivityTrackingUtils {
return components.url
}
}
#endif
2 changes: 1 addition & 1 deletion ...K/OneSignalSDK/OneSignalLiveActivities/Source/Requests/OSRequestLiveActivityClicked.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ class OSRequestLiveActivityClicked: OneSignalRequest, OSLiveActivityRequest {
return false
}

guard let activityType = self.key.addingPercentEncoding(withAllowedCharacters: NSCharacterSet.urlUserAllowed) else {
guard let activityType = self.activityType.addingPercentEncoding(withAllowedCharacters: NSCharacterSet.urlUserAllowed) else {
OneSignalLog.onesignalLog(.LL_DEBUG, message: "Cannot translate activity type to url encoded string.")
return false
}
Expand Down
Loading